-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tooltip): tooltip-v2 - aligned to how popover functions #235
refactor(tooltip): tooltip-v2 - aligned to how popover functions #235
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@pawel-twardziak is attempting to deploy a commit to the Radix-angular Team on Vercel. A member of the Team first needs to authorize it. |
@pimenovoleg yes, that's ok because the second and the third of the multiple case story have side offset and align offset applied. Maybe I should add an info about it to them, what do you thing? You feel confused w/o that info so the other can also feel the same, I think :) |
@pimenovoleg |
btw @pimenovoleg when I click deployment vercel links I see this: It would be nice to have an access but w/o it is also ok :) |
Yes, I think adding some information about the side and align offsets would be really helpful. It makes the examples more self-explanatory, especially for someone reviewing them for the first time. Maybe a short comment or a note in the documentation near the example would work well. What do you think? 😊 |
Yes, I definitely agree :) What about this:
Make sense? :) |
I changed some settings, please try creating a PR from a branch instead of a fork next time. |
@pimenovoleg can I continue on this by removing the current tiiltip and replacing it with the v2? Then I wanna create |
lets do it 👍 |
@pimenovoleg ready to CR |
Closes #175
@pimenovoleg @mrfrac @artembelik
This is an RC version of
tooltip
-v2 ready to have a lot in common withpopover
. Works perfect :)Once you approve it, I will remove the current
tooltip
and renametooltip
-v2 totooltip
CAUTION: I've left
CloseDirective
as it works fine with external triggering enabled. Just to showcase - can be removed.Overview._.Introduction.-.Docs.Storybook.-.Google.Chrome.2024-12-30.03-10-20.mp4