Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tooltip): tooltip-v2 - aligned to how popover functions #235

Conversation

pawel-twardziak
Copy link
Contributor

@pawel-twardziak pawel-twardziak commented Dec 30, 2024

Closes #175

@pimenovoleg @mrfrac @artembelik
This is an RC version of tooltip-v2 ready to have a lot in common with popover. Works perfect :)
Once you approve it, I will remove the current tooltip and rename tooltip-v2 to tooltip

CAUTION: I've left CloseDirective as it works fine with external triggering enabled. Just to showcase - can be removed.

Overview._.Introduction.-.Docs.Storybook.-.Google.Chrome.2024-12-30.03-10-20.mp4

@pawel-twardziak pawel-twardziak self-assigned this Dec 30, 2024
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primitives ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 3:29pm
radix-astro-doc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 3:29pm

Copy link

vercel bot commented Dec 30, 2024

@pawel-twardziak is attempting to deploy a commit to the Radix-angular Team on Vercel.

A member of the Team first needs to authorize it.

@pimenovoleg
Copy link
Contributor

Nice, this version came out super quickly! :)

While reviewing the examples, I noticed a strange indentation here. Is everything okay with it?
In multiple section, secondary example.

image

@pawel-twardziak
Copy link
Contributor Author

Nice, this version came out super quickly! :)

While reviewing the examples, I noticed a strange indentation here. Is everything okay with it? In multiple section, secondary example.

@pimenovoleg yes, that's ok because the second and the third of the multiple case story have side offset and align offset applied. Maybe I should add an info about it to them, what do you thing? You feel confused w/o that info so the other can also feel the same, I think :)

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Dec 30, 2024

@pimenovoleg
would this be ok?
obraz

@pawel-twardziak
Copy link
Contributor Author

btw @pimenovoleg when I click deployment vercel links I see this:
obraz

It would be nice to have an access but w/o it is also ok :)

@pimenovoleg
Copy link
Contributor

Nice, this version came out super quickly! :)
While reviewing the examples, I noticed a strange indentation here. Is everything okay with it? In multiple section, secondary example.

@pimenovoleg yes, that's ok because the second and the third of the multiple case story have side offset and align offset applied. Maybe I should add an info about it to them, what do you thing? You feel confused w/o that info so the other can also feel the same, I think :)

Yes, I think adding some information about the side and align offsets would be really helpful. It makes the examples more self-explanatory, especially for someone reviewing them for the first time. Maybe a short comment or a note in the documentation near the example would work well. What do you think? 😊

@pawel-twardziak
Copy link
Contributor Author

Yes, I think adding some information about the side and align offsets would be really helpful. It makes the examples more self-explanatory, especially for someone reviewing them for the first time. Maybe a short comment or a note in the documentation near the example would work well. What do you think? 😊

Yes, I definitely agree :)

What about this:

@pimenovoleg would this be ok? obraz

Make sense? :)

@pimenovoleg
Copy link
Contributor

btw @pimenovoleg when I click deployment vercel links I see this: obraz

It would be nice to have an access but w/o it is also ok :)

I changed some settings, please try creating a PR from a branch instead of a fork next time.

@pawel-twardziak
Copy link
Contributor Author

@pimenovoleg can I continue on this by removing the current tiiltip and replacing it with the v2? Then I wanna create hover card and next that one #236

@pimenovoleg
Copy link
Contributor

@pimenovoleg can I continue on this by removing the current tiiltip and replacing it with the v2? Then I wanna create hover card and next that one #236

lets do it 👍

@pawel-twardziak
Copy link
Contributor Author

@pimenovoleg ready to CR

@pawel-twardziak pawel-twardziak merged commit f8263db into radix-ng:main Dec 30, 2024
5 of 9 checks passed
@pawel-twardziak pawel-twardziak deleted the feature/tooltip/175-onscroll--changing-trigger-position-behaviour branch December 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request type: primitives
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Primitive] Tooltip: onscroll & changing trigger position behaviour (when open state is controlled)
2 participants